-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes typing with @types/react@18 #67
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Watching the fixes into Fresnel I remembered how responsive is done in HeCo and I found this hook interesting: Its use seems simpler than the Fresnel denominators. |
The main reason is that in nextjs we need a SSR way of dealing with media queries. Otherwise we will see a first render that doesn't match the final view in some cases. Like showing the full header before it transforms to a hamburger icon... |
It seems that they have a fix, they will show something next week. I think it's safe to merge this PR right now, but we need to add a reminder to check this in the following weeks |
Fixes some typing issues through:
react-query@3
to@tanstack/react-query@4
framer-motion@7
@artsy/[email protected]
@react-aria
and@react-stately
libraries. Removes temporary@react-stately/slider
resolution.Most updates (but
@fresnel
) fix the children typing issue in React@18 by upgrading to latest versions.There's an issue with @fresnel: the library doesn't specify the prop
children
in its provider when@types/react@18
is enabled so we need to wait for an update that changes this. Meanwhile, instead of dealing with weird typing on our end to fix the error, I think it's better to disable TS for that specific line, add a comment and wait for the solution coming from the library itself.Please, run
rm -rf node_modules && yarn
for a fresh install and ensure types are correct runningyarn check-types
command.