Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAIN: Fix warnings from dev dependencies #156

Merged
merged 3 commits into from
Mar 25, 2020
Merged

MAIN: Fix warnings from dev dependencies #156

merged 3 commits into from
Mar 25, 2020

Conversation

Weetbix
Copy link
Contributor

@Weetbix Weetbix commented Mar 25, 2020

Fixes security warnings for dev dependencies of our dependencies (minimist + acorn).

  • As part of this, the yarn node_modules structure seems to have changed and plugins are no longer working with ESLint unless they are specified in the package json, see: ESLint does not support plugins as dependencies of shared configs javascript-linters#2
    so thats why I added the prettier plugin to the package.json
  • Prettier 2.0 has new defaults, mainly trailing commas and brackets for single param arrow functions. This project checks lint rules on commit, so Ive updated the files that were breaking because of this change.
  • Ran yarn upgrade (fixes acorn dep)
  • Added another module resolution for the karmatic sub module as there is no fix released yet for karmatic

@Weetbix Weetbix requested a review from lanwen March 25, 2020 10:19
@Weetbix Weetbix merged commit 08832fd into master Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants