Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C# binding #184

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

C# binding #184

wants to merge 7 commits into from

Conversation

bramhoven
Copy link

This is still a W.I.P. but I wanted to publish it already in case anybody had any feedback or improvements!

This would be the PR for #152

Copy link
Owner

@VivekPanyam VivekPanyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

I didn't look at the changes in depth yet, but here's a high level note so far:

Can you create a .gitignore file inside source/carton-bindings-csharp/ and ignore all the autogenerated files?

Also, can you add a build script in that directory that generates files and builds the library?

That should make this PR much smaller than the 16k lines it currently is :)

Thanks for spending time on this!

@bramhoven
Copy link
Author

@VivekPanyam I added the .gitignore, so it should be more readable now!

Copy link
Owner

@VivekPanyam VivekPanyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add cross-platform-ast.json and the *.gen.cs files to source/carton-bindings-csharp/.gitignore as well please?

Also, feel free to mark the PR as ready for review when it's ready for a more in-depth review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants