-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C# binding #184
base: main
Are you sure you want to change the base?
C# binding #184
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
I didn't look at the changes in depth yet, but here's a high level note so far:
Can you create a .gitignore
file inside source/carton-bindings-csharp/
and ignore all the autogenerated files?
Also, can you add a build script in that directory that generates files and builds the library?
That should make this PR much smaller than the 16k lines it currently is :)
Thanks for spending time on this!
a9daf2e
to
902af2f
Compare
@VivekPanyam I added the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add cross-platform-ast.json
and the *.gen.cs
files to source/carton-bindings-csharp/.gitignore
as well please?
Also, feel free to mark the PR as ready for review when it's ready for a more in-depth review!
902af2f
to
654581b
Compare
This is still a W.I.P. but I wanted to publish it already in case anybody had any feedback or improvements!
This would be the PR for #152