-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.20.4] Many API Additions #255
Open
hammy275
wants to merge
23
commits into
Vivecraft:Multiloader-1.20.4
Choose a base branch
from
hammy275:vivecraft-api-1.20.4
base: Multiloader-1.20.4
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[1.20.4] Many API Additions #255
hammy275
wants to merge
23
commits into
Vivecraft:Multiloader-1.20.4
from
hammy275:vivecraft-api-1.20.4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 24, 2024
Closed
hammy275
force-pushed
the
vivecraft-api-1.20.4
branch
from
August 30, 2024 15:02
7c311a2
to
e8198a4
Compare
Rebased onto Unrelated, but if it makes life easier, I'm happy to rebase this after #284 is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A 1.20.4 port of #184 . This also adds a couple of new changes:
isVanillaRenderPass()
to the bottom of the file, since its still marked@Beta
. Perhaps we want to make aVivecraftRenderingAPI
or something, just for organization?isFirstRenderPass()
andgetCurrentRenderPass()
, as requested.All features can be tested with this test mod. Note that the test mod itself has only been tested on Fabric, but should work in Forge.