Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back local variable names and comments #248

Open
wants to merge 1 commit into
base: Multiloader-1.20
Choose a base branch
from

Conversation

kevina
Copy link

@kevina kevina commented Feb 15, 2024

Between 1.16 and 1.17 all local variables and comments were somehow lost. It looks like the source code was decompiled from compiled class files for some reason. This makes understanding the code very difficult.

In order to better understand the code I used the code for 1.16 for reference and added back local variables and comments when there was an obvious match. I did not add back commented out code, unless it looked useful for debugging. I did not make any other changes. There should, theoretically, be no changes in the bytecode.

Let me know if this is something that is wanted. I currently only did two files, but may do more in the future as I work to understand the code.

@fayer3
Copy link
Member

fayer3 commented Feb 15, 2024

I do plan to do that at some point, blindly readding the old names isn't the best, sinece some stuff changed

@kevina
Copy link
Author

kevina commented Feb 15, 2024

Blindly readding the old names isn't the best, sinece some stuff changed

I wouldn't call it blindly, I am doing it as I am trying to understand the code, so I make sure the old names still make sense.

@fayer3
Copy link
Member

fayer3 commented Feb 15, 2024

I would probably prefer to do that myself, since I would maybe do some changes

@fayer3
Copy link
Member

fayer3 commented Feb 15, 2024

also I already did swingtracker in this pr, isn't merged yet though #221

@kevina
Copy link
Author

kevina commented Feb 15, 2024

I would probably prefer to do that myself, since I would maybe do some changes

Understandable.

also I already did swingtracker in this pr, isn't merged yet though #221

Okay. I removed swingtracker from the commit.

I won't put any effort in doing any other files, at least for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants