Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup logging #193

Open
wants to merge 2 commits into
base: Multiloader-1.20.2
Choose a base branch
from
Open

Conversation

NicBOMB
Copy link

@NicBOMB NicBOMB commented Oct 10, 2023

This branch unifies the various methods for logging into a single import from the common Utils.
This branch also moves the message helper from CilentDataHolderVR to the client utils.
Duplicate checkGLerror functions were unified in the VRPassHelper.
Some org.vivecraft.common.utils.Utils.logger. can be shortened to just Utils. when the client Utils for math functions are removed.

@ferriarnus
Copy link
Member

2 Classes named utils isn't really good imo. I need to look at why it's even needed for the logger to be split, but in case we need common and client classes, we should call them CommonUtil and ClientUtil or something.

@fayer3
Copy link
Member

fayer3 commented Oct 10, 2023

the common.utils.Utils class is from me

@ferriarnus
Copy link
Member

Doesn't really matter where it came from, but if we are using both in the same file, imports get messy. We might need a split because of access to the Minecraft instance, but then we need to change the names so it's more clear which is safe to call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants