Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Parchment mappings #189

Open
wants to merge 1 commit into
base: Multiloader-1.20.2
Choose a base branch
from

Conversation

NicBOMB
Copy link

@NicBOMB NicBOMB commented Oct 9, 2023

I've been using them on recommendation from @fayer3 a few months ago and can confirm they have been very helpful.

@ferriarnus
Copy link
Member

Oh we didn't have parchement set up? Yeah it's good to add it.

@fayer3
Copy link
Member

fayer3 commented Oct 9, 2023

if we add Parchment we should also go through, and change all arguments to the parchment names, imo

@ferriarnus
Copy link
Member

If we have some mojang names like p_037392, then yeah it would be worth to update those. Changing "color" to "pColor" is not worth it imo. That also doesn't need to be part of this PR, but it could be nice to do it here.

@NicBOMB
Copy link
Author

NicBOMB commented Oct 9, 2023

if we add Parchment we should also go through, and change all arguments to the parchment names, imo

If we have some mojang names like p_037392, then yeah it would be worth to update those. Changing "color" to "pColor" is not worth it imo. That also doesn't need to be part of this PR, but it could be nice to do it here.

I was going to make those changes in the add parchment mappings commit, but decided against it. Adding it to the build and using it should be separate commits. I can add another commit applying Parchment names to this PR.

@fayer3 fayer3 mentioned this pull request Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants