DEX: read_uleb128_bounded(), fix buffer-overflow
#1949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to read ULEB128 encoded values close to the end of a buffer. This change fixes a heap-buffer-overflow in `load_encoded_method()`, found by fuzzing. In that method, the `fits_in_dex()` check is not sufficient, as each `uint32_t` can occupy up to 5 bytes in ULEB128 encoding. I did not replace all uses of `read_uleb128()` in `dex.c`, but follow-up changes should probably do that.
plusvic
approved these changes
Aug 16, 2023
cblichmann
added a commit
to cblichmann/yara
that referenced
this pull request
Aug 17, 2023
This is a follow-up to PR VirusTotal#1949, replacing all remaingin uses of `read_uleb128()` in `dex.c`. It also fixes another heap-buffer-overflow, again found by fuzzing. Tested with `test-dex.c`
plusvic
pushed a commit
that referenced
this pull request
Aug 18, 2023
This is a follow-up to PR #1949, replacing all remaingin uses of `read_uleb128()` in `dex.c`. It also fixes another heap-buffer-overflow, again found by fuzzing. Tested with `test-dex.c`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to read ULEB128 encoded values close to the end of a buffer.
This change fixes a heap-buffer-overflow in
load_encoded_method(), found by fuzzing. In that method, thefits_in_dex()check is not sufficient, as eachuint32_tcan occupy up to 5 bytes in ULEB128 encoding.I did not replace all uses of
read_uleb128()index.c, but follow-up changes should probably do that.