fix several endianness issues in PE modules #1884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those were all bugs affecting big-endian architectures: - The length field in resources string was read without endianness correction, leading to the `name_string`, `language_string` and `type_string` in `pe.resources[*]` not being properly set. - `pe.size_of_optional_header` was not using the right size for endianness correction. - `pe.opthdr_magic` was not using the right size for endianness correction. - `pe.dll_characteristics` was not using the right size for endianness correction. - `pe.data_directories` was not correctly filled at all, due to not using the right size for endianness correction when reading `NumberOfRvaAndSizes`. - The `entrypoint` operator was not returning the right value, as the VirtualSize field was read without endianness correction. This operator is deprecated, but the fix is very trivial.
plusvic
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those were all bugs affecting big-endian architectures:
name_string,language_stringandtype_stringinpe.resources[*]not being properly set.pe.size_of_optional_headerwas not using the right size for endianness correction.pe.opthdr_magicwas not using the right size for endianness correction.pe.dll_characteristicswas read without endianness correction.pe.data_directorieswas not correctly filled at all, due to not using the right size for endianness correction when readingNumberOfRvaAndSizes.entrypointoperator was not returning the right value, as the VirtualSize field was read without endianness correction. This operator is deprecated, but the fix is very trivial.