Fix another compiler edge case. #1722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When compiling and we encounter a range that has values we can determine at compile time we should error out if the lower bound is less than 0.
wxsBSD
force-pushed
the
more_compiler_edge_cases
branch
from
858fef7
to
8b99302
Compare
The OP_COUNT_IN operation does not need the paranoid check on r1 as it is the lower bound of the range, and thus a constant and not a pointer somewhere. It should, instead, be checking r3. Fixes VirusTotal#1721 (the first half of it).
wxsBSD
force-pushed
the
more_compiler_edge_cases
branch
from
8b99302
to
141a38b
Compare
plusvic
approved these changes
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling and we encounter a range that has values we can determine at
compile time we should error out if the lower bound is less than 0.
Fixes #1721 (at least part of it).