Add a "not" operator for hex bytes #1676
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When specifying hex strings, we run across cases where we want to specify that a byte in not a specific value.
eg.
$want = " { 81 FE ?? ?? ?? ?? 7F } $dont_want = " { 81 FE ?? ?? ?? 00 7F }
This pull request adds a not operator (~) on bytes so you could specify:
$want_and_dont_want = " { 81 FE ?? ?? ?? ~00 7F }
This seems to be pretty straightforward and useful. At the moment only individual bytes can be negated, but it could be easily expanded to cover negated masked bytes such a
~7?
More complex would be expressing as a general construct so you can have things like
~(00 | 01)
but I'm not sure how far we want to go in expanding hex strings to be a complete regex language in it's own right.