Improve atom extraction logic #1656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarterp
pushed a commit
to mandiant/yara
that referenced
this pull request
Mar 31, 2022
Fix issue VirusTotal#1646 by generalizing the solution provided in VirusTotal#1647. Atoms with a higher number of unique bytes are prioritized over atoms that have repeated characters. Also fixes issue VirusTotal#1654, which was discovered in a debug session, but has been there for a long time.
maximelb
pushed a commit
to refractionPOINT/yara
that referenced
this pull request
Nov 17, 2022
Fix issue VirusTotal#1646 by generalizing the solution provided in VirusTotal#1647. Atoms with a higher number of unique bytes are prioritized over atoms that have repeated characters. Also fixes issue VirusTotal#1654, which was discovered in a debug session, but has been there for a long time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #1646 by generalizing the solution provided in #1647. Atoms with a higher number of unique bytes are prioritized over atoms that have repeated characters.
Also fixes issue #1654, which was discovered in a debug session, but has been there for a long time.