Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update YARA Sandboxed API for 4.0 #1276

Merged
merged 2 commits into from
May 12, 2020
Merged

Update YARA Sandboxed API for 4.0 #1276

merged 2 commits into from
May 12, 2020

Conversation

cblichmann
Copy link
Contributor

This PR updates YARA's sandbox to use the latest Sandboxed API and makes it compatible to the API changes in YARA 4.0.

Other changes:

  • Updated Bazel dependencies to use maybe()
  • Update to latest Abseil and newer GoogleTest to match what Sandboxed API uses (to avoid duplication)
  • Force C++ parts to be build with C++17, as that is required for the sandbox

@cblichmann
Update Bazel dependencies
67f35b3 
This also fixes a `borinssl` typo in the repository rules
@cblichmann
Update YARA Sandboxed API sandbox
b9dc411 
- Compatiblity with YARA 4.0
- Fix issues due to newer Sandboxed API
- Use public Abseil API and the new absl::Status
@cblichmann
Copy link
Contributor Author

I believe the CIFuzz errors are unrelated. The root cause seems to be a missing yacc for generating YARA's lexer/parser.

@plusvic plusvic merged commit f014492 into VirusTotal:master May 12, 2020
@cblichmann cblichmann deleted the update-sapi branch May 12, 2020 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cblichmann @plusvic