Skip to content

Commit

Permalink
Update binaryen and fix tests (emscripten-core#8499)
Browse files Browse the repository at this point in the history
*    f32s are no longer legalized by binaryen
*    Adding pthread_setcanceltype to pthread stubs (emscripten-core#8480) did not update the test properly, update it now.
  • Loading branch information
kripken authored and VirtualTim committed May 21, 2019
1 parent e92a55f commit a89389d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions tests/test_other.py
Original file line number Diff line number Diff line change
Expand Up @@ -8040,7 +8040,7 @@ def run(*args):
0, [], [], 8, 0, 0, 0) # noqa; totally empty!
# we don't metadce with linkable code! other modules may want stuff
run(['-O3', '-s', 'MAIN_MODULE=1'],
1542, [], [], 226403, 30, 95, None) # noqa; don't compare the # of functions in a main module, which changes a lot
1543, [], [], 226403, 30, 95, None) # noqa; don't compare the # of functions in a main module, which changes a lot

# ensures runtime exports work, even with metadce
def test_extra_runtime_exports(self):
Expand Down Expand Up @@ -8090,7 +8090,7 @@ def test_legalize_js_ffi(self):
assert not i_i64_i64, 'i64 not converted to i32 in imports'
assert not i_f32_f32, 'f32 not converted to f64 in imports'
assert e_i64_i32, 'i64 not converted to i32 in exports'
assert e_f32_f64, 'f32 not converted to f64 in exports'
assert not e_f32_f64, 'f32 not converted to f64 in exports'
assert not e_i64_i64, 'i64 not converted to i64 in exports'
else:
assert not i_i64_i32, 'i64 converted to i32 in imports'
Expand Down
2 changes: 1 addition & 1 deletion tools/ports/binaryen.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
import os
import logging

TAG = 'version_82'
TAG = 'version_83'


def needed(settings, shared, ports):
Expand Down

0 comments on commit a89389d

Please sign in to comment.