Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VCST-2621: Small fix and refactoring #444

Merged
merged 3 commits into from
Feb 24, 2025
Merged

VCST-2621: Small fix and refactoring #444

merged 3 commits into from
Feb 24, 2025

Conversation

OlegoO
Copy link
Contributor

@OlegoO OlegoO commented Feb 13, 2025

Description

fix: Reorganized and reformatted JSON files for multiple locales (de, en, es, fr, it, ja, pl, pt, ru, zh) to ensure consistency and completeness of order management information.

fix: Updated payment-detail.tpl.html to conditionally display payment method details only if available, preventing UI issues.

References

QA-test:

Jira-link:

https://virtocommerce.atlassian.net/browse/VCST-2621

Artifact URL:

https://vc3prerelease.blob.core.windows.net/packages/VirtoCommerce.Orders_3.841.0-pr-444-37db.zip

fix: Reorganized and reformatted JSON files for multiple locales (de, en, es, fr, it, ja, pl, pt, ru, zh) to ensure consistency and completeness of order management information.

fix: Updated `payment-detail.tpl.html` to conditionally display payment method details only if available, preventing UI issues.
@OlegoO OlegoO requested a review from ksavosteev February 13, 2025 12:30
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.374
Timestamp: 13-02-2025T12:59:35

ksavosteev
ksavosteev previously approved these changes Feb 13, 2025
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 8.66
Timestamp: 24-02-2025T10:13:38

@OlegoO OlegoO merged commit 4b97206 into dev Feb 24, 2025
5 checks passed
@OlegoO OlegoO deleted the fix/VCST-2621 branch February 24, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants