Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify ReturningMethod type so that it avoids infinite type recursion #2278

Closed
wants to merge 1 commit into from
Closed

Simplify ReturningMethod type so that it avoids infinite type recursion #2278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 2 additions & 4 deletions typings/objection/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -628,11 +628,9 @@ declare namespace Objection {
<QB extends AnyQueryBuilder>(
this: QB,
column: string | string[]
): QB extends ArrayQueryBuilder<QB>
): QB extends NumberQueryBuilder<QB>
? ArrayQueryBuilder<QB>
: QB extends NumberQueryBuilder<QB>
? ArrayQueryBuilder<QB>
: SingleQueryBuilder<QB>;
: QB;
}

interface TimeoutOptions {
Expand Down