Improve iterator #34
Merged
Improve iterator #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 9, 2022 11:03
Reseting the iterator was made up of two parts. In the first part the signature is reset, and the second part was reseting the fragment trackers. I split this into two methods so that users could have access to both.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to enhance the iterator functionality of PyModifiedPeptide in the Python API as detailed in #33. Users will be able to iterate over signatures and the underlying fragments with much more ease. This PR also adds a brief introduction to using this class in Python. As the class improves, I want to add even more detailed information, or even add a new page which is entitled
building a scoring pipeline.