Request to Join Commit Team #2168
Open
+10
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add rails 8 appraisal * add rails 8 ci * fix lint * updatre gemfile * fix lint * fix specs * fix specx=cs again * fix specs * fix specs * f*** these specs already * fix lint * fix benchmarks * f*** these specs already * fix lint * fis spcs * fix ci * Update test/sandbox/test/rendering_test.rb Co-authored-by: Cameron Dutro <[email protected]> * fix ci * fix lint * fix lint * try fix benchmark ci * Apply suggestions from code review * Update test/sandbox/test/rendering_test.rb --------- Co-authored-by: Cameron Dutro <[email protected]> Co-authored-by: Joel Hawksley <[email protected]>
reeganviljoen
force-pushed
the
rv_add_reegab_to_commiters_team
branch
from
2c93810
to
a37799e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
After participating in 20 released features/bugs so far over almost a year and a half(wow that long already) and being of use in triaging issues, my contribution to this project has been a highlight of this time truly, and I would love nothing more than to stay on this journey of building the future of the Rails UI layer for the world to use. I feel being a part of this team will enable me to do this to an even better degree in the future as we head for V4. I feel this will help me be of use when people are struggling to get their pr's further across the line when everyone else is busy(we all do this when we can but that's sometimes a tough thing to do).
I would really appreciate this being taken into consideration
Thank you to the whole team that continues to make this possible everyday 🥇