Add helper instrumentation #2072
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @reeganviljoen, thanks for this! I don't think this is something we necessarily want in the framework. I would recommend people add it to their apps directly. |
|
@camertron I have thought about this over the past few days, and I feel you have a point so I will close this pull request and I thank you for your feedback 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Add instrumentation to helpers, this will help people trying to migrate away from using helpers to log incidents to services like sentry
This was a suggestion by @danini-the-panini on #1987 and I feel it is a good addition
What approach did you choose and why
Added a new method to the instrumentation that overrides helpers to instrument it