-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Ruby head and YJIT to CI #2030
add Ruby head and YJIT to CI #2030
Conversation
@joelhawksley I have created this pr for the reasons listed in the description, can you please take another look at this when you can, I also know we are starting to fail on rails head so I will investigate that when I can |
Thanks for working on this @reeganviljoen! What would you think about always enabling YJIT? Is there a reason we would want to disable it, other than a particular Ruby version not supporting it? We def need to fix those test failures for Ruby head and Rails head. I wonder if those could be separate PRs? |
@camertron I think it would be wise to enable both as some users still use MRI without YJIT, I am just a bit worried a bug in MRI is missed because we only test against YJIT
I have already started working ion the rails head issues, spoiler the backtrace is working very differently now, but am having issues building ruby dev locally |
Ok that's fair, I just worry that our build matrix is getting awfully large 😵
Awesome thank you! Let me know if I can help re: build issues. |
@camertron i do agree it's getting large, maybe we can remove all unsupported rails and ruby version from the matrix |
Yeah, I've considered that... I feel bad about it tho since so many people aren't using the latest versions, and we've always sort of said we'd support older Rails/Ruby versions as long as they were easy to support. So I guess we keep them in the matrix for now. |
@camertron maybe as a compromise we can have a sunsetting deadline for older version support ? |
@reeganviljoen yeah, I can bring it up again at our next sync meeting. |
@camertron Thanks much appreciated turns out I was missing a few build dependencies, it works lovely now, the ruby head issue is a mismatched regexp encoding(ASCII) with a matched string(UTF-8) I believe this is a bug, I will report it tomorrow to https://bugs.ruby-lang.org/ |
|
@joelhawksley @camertron @boardfish @Spone everything is finally passing on this PR can we get a look at it please 🙏 |
@reeganviljoen thanks again, this is lovely ❤️ |
What are you trying to accomplish?
I created this pr as a continuation of #2012 as a separate branch so @joelhawksley and anyone else can add to this branch
Add ruby head to CI as well as YJIT as discussed in #2010 by me and @joelhawksley
Anything you want to highlight for special attention from reviewers?
Ruby head seems to have to be failing on CI which needs further investigation into whether it is a ruby bug or if it really is a breaking change