Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operator fixes: #935

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Operator fixes: #935

merged 2 commits into from
Apr 23, 2024

Conversation

Haleygo
Copy link
Contributor

@Haleygo Haleygo commented Apr 23, 2024

  1. address bearerTokenSecret missing on Conversion from ServiceMonitor to VMServiceScrape since 0.43.0 #932, fix ServiceMonitor to VMServiceScrape conversion, before bearerTokenSecret is dropped by mistake since v0.43.0
  2. fix selector match for config resources like VMUser, VMRule... , before it could be ignored when update resource labels.

1.fix `ServiceMonitor` to `VMServiceScrape` conversion, before `bearerTokenSecret` is dropped mistakenly since v0.43.0
…fore it could be ignored when update resource labels
Copy link
Collaborator

@f41gh7 f41gh7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@f41gh7 f41gh7 merged commit 4d47f04 into master Apr 23, 2024
2 checks passed
@f41gh7 f41gh7 deleted the operator-fixes branch April 23, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants