Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add custom-dashboards path to VMUser's VMSelect pre-defined path #791

Merged
merged 1 commit into from
Oct 30, 2023
Merged

fix: add custom-dashboards path to VMUser's VMSelect pre-defined path #791

merged 1 commit into from
Oct 30, 2023

Conversation

raskyld
Copy link
Contributor

@raskyld raskyld commented Oct 28, 2023

Context

When using VMUser's vmuser.spec.targetRefs.crd with a VMCluster/vmselect reference, the list of predefined path does not include /prometheus/vmui/custom-dashboards which causes a 400 when accessing VMUI behind VMAuth.

@raskyld
Copy link
Contributor Author

raskyld commented Oct 28, 2023 •
edited
Loading

FYI, this is the slack thread where we (with @dmitryk-dk) hunted the bug down.
Thanks a lot! 🚀

f41gh7
f41gh7 approved these changes Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@f41gh7 f41gh7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@f41gh7 f41gh7 merged commit f048c95 into VictoriaMetrics:master Oct 30, 2023
1 check failed
@f41gh7
Copy link
Collaborator

f41gh7 commented Oct 30, 2023

Thanks for contribution!

@Amper
Copy link
Contributor

Amper commented Oct 30, 2023 •
edited
Loading

image

@raskyld
Copy link
Contributor Author

raskyld commented Oct 30, 2023

Sorry for the Changelog! I blindly followed https://github.com/VictoriaMetrics/operator/blob/master/CONTRIBUTING.md,
how do you handle changelogs? I didn't see a CHANGELOG file at the root of the repository 🙈

@f41gh7
Copy link
Collaborator

f41gh7 commented Nov 1, 2023

Sorry for the Changelog! I blindly followed https://github.com/VictoriaMetrics/operator/blob/master/CONTRIBUTING.md, how do you handle changelogs? I didn't see a CHANGELOG file at the root of the repository 🙈

Sorry, we have to update contributing guide. Any changes must be mentioned at docs/CHANGELOG.md file. I've made a commit with this change 690b208

@raskyld
Copy link
Contributor Author

raskyld commented Nov 1, 2023

No problem! Thanks for the back-up! 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f41gh7 f41gh7 f41gh7 approved these changes

@Amper Amper Awaiting requested review from Amper

@Haleygo Haleygo Awaiting requested review from Haleygo Haleygo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raskyld @f41gh7 @Amper