Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(vmagent, vmauth): use proper flag for custom configmap reloader init container #771

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Fix(vmagent, vmauth): use proper flag for custom configmap reloader init container #771

merged 1 commit into from
Oct 2, 2023

Conversation

ebensom
Copy link
Contributor

@ebensom ebensom commented Oct 2, 2023

  • Use the --only-init-config flag for custom configmap reloader init container in vmauth and vmagent deployments.
  • Update the default custom config reloader image to v0.38.0.

Fixes #770 .

f41gh7
f41gh7 approved these changes Oct 2, 2023
View reviewed changes
Copy link
Collaborator

@f41gh7 f41gh7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@f41gh7 f41gh7 merged commit 217e152 into VictoriaMetrics:master Oct 2, 2023
1 check failed
@f41gh7
Copy link
Collaborator

f41gh7 commented Oct 2, 2023

Thanks for contribution!

@ebensom ebensom deleted the fix-custom-config-reloader-init branch October 2, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f41gh7 f41gh7 f41gh7 approved these changes

@Amper Amper Awaiting requested review from Amper

@Haleygo Haleygo Awaiting requested review from Haleygo Haleygo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom reloader init containers cannot start in vmauth and vmagent pods
2 participants
@ebensom @f41gh7