Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keep_metric_names is missing in StreamAggrRule #936

Closed
zigmund opened this issue Apr 23, 2024 · 1 comment
Closed

keep_metric_names is missing in StreamAggrRule #936

zigmund opened this issue Apr 23, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@zigmund
Copy link

zigmund commented Apr 23, 2024

According to docs:
https://docs.victoriametrics.com/stream-aggregation/#output-metric-names
https://docs.victoriametrics.com/stream-aggregation/#stream-aggregation-config
there is keep_metric_names option to keep original metric name after the aggregation.

But operator (v0.43.2) doesn't support it, checked vmagent crd - no such field.
@Haleygo Haleygo added the enhancement New feature or request label Apr 25, 2024
f41gh7 added a commit that referenced this issue May 7, 2024
@f41gh7
api: adds new fields to the streamAggrConfig
5d131f6 
It keeps in-sync operator CRD definition with vmagent upstream

#936
@f41gh7
Copy link
Collaborator

f41gh7 commented May 10, 2024

Changes included to the v0.44.0 release

@f41gh7 f41gh7 closed this as completed May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zigmund @f41gh7 @Haleygo