Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support discord_configs in alertmanager config #808

Closed
recht opened this issue Nov 21, 2023 · 4 comments
Closed

Support discord_configs in alertmanager config #808

recht opened this issue Nov 21, 2023 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@recht
Copy link

recht commented Nov 21, 2023

Alertmanager supports discord_configs in receivers, so it would be nice to have that reflected in VM too.
@f41gh7 f41gh7 added the enhancement New feature or request label Nov 21, 2023
@Haleygo Haleygo added the help wanted Extra attention is needed label Nov 28, 2023
@bh-tt
Copy link
Contributor

bh-tt commented Jan 10, 2024

Additionally, I'm missing: msteams_configs, sns_configs and webex_configs.

@bh-tt
Copy link
Contributor

bh-tt commented Jan 15, 2024

@Haleygo I'm willing to implement this, do you have an overview of what needs to be changed?

I suppose I need to add the new receiver types here and then add something to the alertmanagerconfig generation code here?

@Haleygo
Copy link
Contributor

Haleygo commented Jan 15, 2024

@Haleygo I'm willing to implement this, do you have an overview of what needs to be changed?

I suppose I need to add the new receiver types here and then add something to the alertmanagerconfig generation code here?

@bh-tt Yes, that's about it)

@Haleygo Haleygo removed their assignment Jan 15, 2024
bh-tt added a commit to bh-tt/vm-operator that referenced this issue Jan 15, 2024
@bh-tt
Fix VictoriaMetrics#808, adding additional receiver config types
393052b
bh-tt added a commit to bh-tt/vm-operator that referenced this issue Jan 19, 2024
@bh-tt
Fix VictoriaMetrics#808, adding additional receiver config types
3ac580f 
Add discord, sns and webex configs

Run make test
@bh-tt
Copy link
Contributor

bh-tt commented Jan 26, 2024

I've tried msteams_configs today and it works!

This was referenced Mar 26, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@recht @f41gh7 @Haleygo @bh-tt