Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vmalertmanager: operator always requests memory #706

Closed
uhthomas opened this issue Jul 26, 2023 · 1 comment
Closed

vmalertmanager: operator always requests memory #706

uhthomas opened this issue Jul 26, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@uhthomas
Copy link

The operator will always apply a memory request of 200Mi to the Alertmanager pod, even if limits are already set. This is problematic if the limit is lower than the request, or if the user does not want an explicit request. I usually only set limits, as the Kubernetes API will automatically set the requests to match those limits and the QOS class will then be considered "Guaranteed". However, the QOS class is considered "Burstable" because of the default memory request. This should just be removed.

if _, ok := cr.Spec.Resources.Requests[v1.ResourceMemory]; !ok {
cr.Spec.Resources.Requests[v1.ResourceMemory] = resource.MustParse("200Mi")
}

image

uhthomas added a commit to uhthomas/vm-operator that referenced this issue Jul 27, 2023
None of the other VM objects have this behaviour and it can cause problems if
the memory limit is lower than the request.

Fixes: VictoriaMetrics#706
@Haleygo Haleygo added the bug Something isn't working label Aug 4, 2023
@Amper
Copy link
Contributor

Amper commented Aug 25, 2023

Added at v0.36.0 release

@Amper Amper closed this as completed Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants