Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vmalert.spec support host_aliases #1099

Closed
Wangyiwei-So opened this issue Sep 11, 2024 · 4 comments
Closed

vmalert.spec support host_aliases #1099

Wangyiwei-So opened this issue Sep 11, 2024 · 4 comments
Labels
enhancement New feature or request waiting for release The change was merged to upstream, but wasn't released yet.

Comments

@Wangyiwei-So
Copy link

Is your feature request related to a problem? Please describe

No response

Describe the solution you'd like

I think vmalert.spec can support host_aliases, like vmagent crd.

Describe alternatives you've considered

No response

Additional information

No response

@Wangyiwei-So Wangyiwei-So added the enhancement New feature or request label Sep 11, 2024
@Haleygo
Copy link
Contributor

Haleygo commented Sep 12, 2024

I'm moving this to operator repo since it's about vmalert CR.

@Haleygo Haleygo transferred this issue from VictoriaMetrics/VictoriaMetrics Sep 12, 2024
@f41gh7
Copy link
Collaborator

f41gh7 commented Sep 12, 2024

Looks like HostAliases setting is also missing at cluster components.

f41gh7 added a commit that referenced this issue Sep 18, 2024
It was added to the all other CRD resources except VMAlert.

 This commit fixes this bug and adds `hostAliases` to the `vmalert.spec`.

Related issue: #1099

Signed-off-by: f41gh7 <[email protected]>
f41gh7 added a commit that referenced this issue Sep 19, 2024
It was added to the all other CRD resources except VMAlert.

 This commit fixes this bug and adds `hostAliases` to the `vmalert.spec`.

Related issue: #1099

Signed-off-by: f41gh7 <[email protected]>
@f41gh7 f41gh7 added the waiting for release The change was merged to upstream, but wasn't released yet. label Sep 19, 2024
@f41gh7
Copy link
Collaborator

f41gh7 commented Sep 20, 2024

Will be fixed at next release.

Operator will support both spec naminghost_aliases and hostAliases. host_aliases has priority over hostAliases.

@f41gh7
Copy link
Collaborator

f41gh7 commented Sep 29, 2024

Inconsistency was fixed at v0.48.3 release.

@f41gh7 f41gh7 closed this as completed Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request waiting for release The change was merged to upstream, but wasn't released yet.
Projects
None yet
Development

No branches or pull requests

3 participants