Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

insecureSkipVerify: ignored in 0.47.0 #1080

Closed
passie opened this issue Aug 23, 2024 · 2 comments
Closed

insecureSkipVerify: ignored in 0.47.0 #1080

passie opened this issue Aug 23, 2024 · 2 comments
Assignees
@f41gh7
Labels
bug Something isn't working

Comments

@passie
Copy link

passie commented Aug 23, 2024

Setting the following parameter in the alertmanager configuration is ignore in the latest operator version. 0.47.0

tls_config:
  insecureSkipVerify: true

Expexted output: (works in 0.46.4)

- name: example-receiver
  email_configs:
  - tls_config:
      insecure_skip_verify: true
    to: [email protected]
    send_resolved: true

Got: (with 0.47.0)

- name: example-receiver
  email_configs:
  - to: [email protected]
    send_resolved: true
@f41gh7 f41gh7 added the bug Something isn't working label Aug 23, 2024
@f41gh7 f41gh7 self-assigned this Aug 23, 2024
f41gh7 added a commit that referenced this issue Aug 23, 2024
@f41gh7
alertmanagerconfig: fixes email tls_config build
b81ae9a 
Previously config builder had incorrect assumption, that tlsConfig for email notifications
  must be build only if requireTLS is set and true.
 But alermanager has requireTLS as true by default and it shouldn't be set to true at configuration.
 Also this param could be managed via global config section.

 This commit removes unneeded if requireTLS is true check before building tls config for email notifications.

Related issue #1080

Signed-off-by: f41gh7 <[email protected]>
@f41gh7
Copy link
Collaborator

f41gh7 commented Aug 23, 2024

An issue will be fixed at the next operator release.

@f41gh7
Copy link
Collaborator

f41gh7 commented Aug 23, 2024

Issue must be fixed at https://github.com/VictoriaMetrics/operator/releases/tag/v0.47.1 release

@f41gh7 f41gh7 closed this as completed Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@f41gh7 f41gh7

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@passie @f41gh7