Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

targetPort dropped from endpoints when converting prometheus operator CRs #1015

Closed
dctrwatson opened this issue Jul 3, 2024 · 2 comments
Closed

targetPort dropped from endpoints when converting prometheus operator CRs #1015

dctrwatson opened this issue Jul 3, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@dctrwatson
Copy link

Looks like when the converters code was moved this was dropped:

operator/controllers/converter/apis.go

Line 350 in 5cef723

TargetPort: endpoint.TargetPort,

@f41gh7 f41gh7 added the bug Something isn't working label Jul 3, 2024
@f41gh7
Copy link
Collaborator

f41gh7 commented Jul 3, 2024

It was dropped at the following commit a5d295b

Will be returned back at 0.46.2

f41gh7 added a commit that referenced this issue Jul 3, 2024
@f41gh7
api: return back TargetPort for VMPodScrape definition
aa71737 
it needs for backward compatibility with prometheus-operator and cannot be removed
#1015
@f41gh7
Copy link
Collaborator

f41gh7 commented Jul 4, 2024

Issue was fixed at v0.46.2 release

@f41gh7 f41gh7 closed this as completed Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dctrwatson @f41gh7