Add HPA support for VMAgent #863
Conversation
There was a problem hiding this comment.
Hello @rakesh-von! Thank you for the PR, please check a few comments.
| @@ -253,6 +253,13 @@ persistence: | |||
| # -- Bind Persistent Volume by labels. Must match all labels of targeted PV. | |||
| matchLabels: {} | |||
|
|
|||
| # Horizontal Pod Autoscaling | |||
| horizontalPodAutoscaler: | |||
There was a problem hiding this comment.
Could you rename it to be autoscaling?
It will make it shorter and less error-prone to use.
There was a problem hiding this comment.
@rakesh-von Sorry for not being completely clear, I suggested renaming horizontalPodAutoscaler to autoscaling. So the whole field name will be shorter.
There was a problem hiding this comment.
@zekker6 in every other chart it is horizontalPodAutoscaler, if i change it to horizontalPodAutoscaling or just autoscaling then vmagent would be the outlier. Are you sure you want this to be renamed to autoscaling?
There was a problem hiding this comment.
@rakesh-von Good point, let's keep it as it is now then. Thanks!
| | horizontalPodAutoscaler.enabled | bool | `false` | Use HPA for vmagent | | ||
| | horizontalPodAutoscaler.maxReplicas | int | `10` | Maximum replicas for HPA to use to to scale vmagent | | ||
| | horizontalPodAutoscaler.minReplicas | int | `1` | Minimum replicas for HPA to use to scale vmagent | | ||
| | horizontalPodAutoscaler.metrics | object | `` | Metric for HPA to use to scale vmagent | |
There was a problem hiding this comment.
Based on values.yaml metrics field should be a list. Could you sync docs to make sure it includes the latest updates from values?
|
Hi @zekker6 , Made the proposed changes, can you please review it now? |
|
Is there a purpose to automatically scaling VMAgent replicas? |
|
@antoinedeschenes it is usefull in multi-layer architecture, using remote-write protocol. Therefore vmagent scraping is not the one that is processing data later in the chain, and we would want to scale these. |
No description provided.