Add Trade Republic English Account statement Parser#352
Open
Janbong wants to merge 1 commit intoVibeNL:masterfrom
Open
Add Trade Republic English Account statement Parser#352Janbong wants to merge 1 commit intoVibeNL:masterfrom
Janbong wants to merge 1 commit intoVibeNL:masterfrom
Conversation
Janbong
force-pushed
the
TR-English-Parser
branch
3 times, most recently
from
0ded39b to
30acbea
Compare
Janbong
force-pushed
the
TR-English-Parser
branch
from
30acbea to
78f63dd
Compare
Owner
|
Good morning, First of all, thanks for adding the pull request. I would start with the unit tests, and for that you would need test pdf's. You can anonymize your own those using the tool in the tool folder to avoid personal data being shared. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, didn't quite get this working yet. Have too little knowledge of the code and C# in general. If you could point me in the right direction.. Thanks!