feat(ketchup): Disabling gzip compression for prometheus

Signed-off-by: Vincent Boutour <[email protected]>
ViBiOh · Jun 6, 2021 · de67e8f · de67e8f
1 parent 22e1d5d
commit de67e8f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/README.md b/README.md
@@ -127,19 +127,21 @@ Usage of ketchup:
   -pathPrefix string
         Root Path Prefix {KETCHUP_PATH_PREFIX}
   -port uint
-        [server] Listen port {KETCHUP_PORT} (default 1080)
+        [server] Listen port (0 to disable) {KETCHUP_PORT} (default 1080)
   -prometheusAddress string
         [prometheus] Listen address {KETCHUP_PROMETHEUS_ADDRESS}
   -prometheusCert string
         [prometheus] Certificate file {KETCHUP_PROMETHEUS_CERT}
+  -prometheusGzip
+        [prometheus] Enable gzip compression of metrics output {KETCHUP_PROMETHEUS_GZIP}
   -prometheusIdleTimeout string
         [prometheus] Idle Timeout {KETCHUP_PROMETHEUS_IDLE_TIMEOUT} (default "10s")
   -prometheusIgnore string
         [prometheus] Ignored path prefixes for metrics, comma separated {KETCHUP_PROMETHEUS_IGNORE}
   -prometheusKey string
         [prometheus] Key file {KETCHUP_PROMETHEUS_KEY}
   -prometheusPort uint
-        [prometheus] Listen port {KETCHUP_PROMETHEUS_PORT} (default 9090)
+        [prometheus] Listen port (0 to disable) {KETCHUP_PROMETHEUS_PORT} (default 9090)
   -prometheusReadTimeout string
         [prometheus] Read Timeout {KETCHUP_PROMETHEUS_READ_TIMEOUT} (default "5s")
   -prometheusShutdownTimeout string

diff --git a/cmd/ketchup/api.go b/cmd/ketchup/api.go
@@ -67,7 +67,7 @@ func main() {
 
 	alcotestConfig := alcotest.Flags(fs, "")
 	loggerConfig := logger.Flags(fs, "logger")
-	prometheusConfig := prometheus.Flags(fs, "prometheus")
+	prometheusConfig := prometheus.Flags(fs, "prometheus", flags.NewOverride("Gzip", false))
 	owaspConfig := owasp.Flags(fs, "", flags.NewOverride("Csp", "default-src 'self'; base-uri 'self'; script-src 'self' 'unsafe-inline'; style-src 'self' 'unsafe-inline'"))
 	corsConfig := cors.Flags(fs, "cors")
 	rendererConfig := renderer.Flags(fs, "", flags.NewOverride("Title", "Ketchup"), flags.NewOverride("PublicURL", "https://ketchup.vibioh.fr"))