fix: Ordering repository by name instead of creation date (#20)

pkg/renderer/handlers.go

@@ -12,7 +12,7 @@ import (
 )
 
 func (a app) getData(r *http.Request) (interface{}, error) {
-	targets, _, err := a.targetApp.List(r.Context(), 1, 100, "", false, nil)
+	targets, _, err := a.targetApp.List(r.Context(), 1, 100, "repository", true, nil)
 
 	return targets, err
 }

pkg/target/db.go

@@ -3,11 +3,16 @@ package target
 import (
 	"database/sql"
 	"fmt"
+	"regexp"
 
 	"github.com/ViBiOh/httputils/v3/pkg/db"
 	"github.com/ViBiOh/ketchup/pkg/model"
 )
 
+var (
+	sortKeyMatcher = regexp.MustCompile(`[A-Za-z0-9]+`)
+)
+
 func scanTarget(row model.RowScanner) (Target, error) {
 	var target Target
 
@@ -53,7 +58,7 @@ SELECT
   count(id) OVER() AS full_count
 FROM
   target
-ORDER BY $3
+ORDER BY %s
 LIMIT $1
 OFFSET $2
 `
@@ -62,16 +67,16 @@ OFFSET $2
 func (a app) listTargets(page, pageSize uint, sortKey string, sortAsc bool) ([]Target, uint, error) {
 	order := "creation_date DESC"
 
-	if sortKey != "" {
+	if sortKeyMatcher.MatchString(sortKey) {
 		order = sortKey
 	}
 	if !sortAsc {
-		order = fmt.Sprintf("%s DESC", order)
+		order += " DESC"
 	}
 
 	offset := (page - 1) * pageSize
 
-	rows, err := a.db.Query(listQuery, pageSize, offset, order)
+	rows, err := a.db.Query(fmt.Sprintf(listQuery, order), pageSize, offset)
 	if err != nil {
 		return nil, 0, err
 	}