refactor(tracer): Renaming span to be closed than code

Signed-off-by: Vincent Boutour <[email protected]>
ViBiOh · Dec 30, 2022 · 65e185f · 65e185f
1 parent 17ad19d
commit 65e185f
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/pkg/crud/upload_chunk.go b/pkg/crud/upload_chunk.go
@@ -69,7 +69,7 @@ func (a App) uploadChunk(w http.ResponseWriter, r *http.Request, request provide
 }
 
 func (a App) mergeChunk(w http.ResponseWriter, r *http.Request, request provider.Request, values map[string]string) {
-	ctx, end := tracer.StartSpan(r.Context(), a.tracer, "mergeChunk")
+	ctx, end := tracer.StartSpan(r.Context(), a.tracer, "merge_chunk")
 	defer end()
 
 	fileName, err := safeFilename(values["filename"])

diff --git a/pkg/metadata/aggregate.go b/pkg/metadata/aggregate.go
@@ -27,14 +27,14 @@ func (a App) GetMetadataFor(ctx context.Context, item absto.Item) (provider.Meta
 		return provider.Metadata{}, nil
 	}
 
-	ctx, end := tracer.StartSpan(ctx, a.tracer, "get_exif")
+	ctx, end := tracer.StartSpan(ctx, a.tracer, "get_metadata")
 	defer end()
 
 	return a.exifCacheApp.Get(ctx, item)
 }
 
 func (a App) GetAllMetadataFor(ctx context.Context, items ...absto.Item) (map[string]provider.Metadata, error) {
-	ctx, end := tracer.StartSpan(ctx, a.tracer, "list_exif")
+	ctx, end := tracer.StartSpan(ctx, a.tracer, "get_all_metadata")
 	defer end()
 
 	exifs, err := a.exifCacheApp.List(ctx, onListError, items...)
@@ -59,14 +59,14 @@ func (a App) GetAggregateFor(ctx context.Context, item absto.Item) (provider.Agg
 		return provider.Aggregate{}, nil
 	}
 
-	ctx, end := tracer.StartSpan(ctx, a.tracer, "aggregate")
+	ctx, end := tracer.StartSpan(ctx, a.tracer, "get_aggregate")
 	defer end()
 
 	return a.aggregateCacheApp.Get(ctx, item)
 }
 
 func (a App) GetAllAggregateFor(ctx context.Context, items ...absto.Item) (map[string]provider.Aggregate, error) {
-	ctx, end := tracer.StartSpan(ctx, a.tracer, "list_aggregate")
+	ctx, end := tracer.StartSpan(ctx, a.tracer, "get_all_aggregate")
 	defer end()
 
 	exifs, err := a.aggregateCacheApp.List(ctx, onListError, items...)

diff --git a/pkg/thumbnail/thumbnail.go b/pkg/thumbnail/thumbnail.go
@@ -216,7 +216,7 @@ func (a App) List(w http.ResponseWriter, r *http.Request, item absto.Item, items
 		return
 	}
 
-	ctx, end := tracer.StartSpan(r.Context(), a.tracer, "thumbnail_list", trace.WithSpanKind(trace.SpanKindInternal))
+	ctx, end := tracer.StartSpan(r.Context(), a.tracer, "list", trace.WithSpanKind(trace.SpanKindInternal))
 	defer end()
 
 	var hash string
@@ -261,7 +261,7 @@ func (a App) List(w http.ResponseWriter, r *http.Request, item absto.Item, items
 }
 
 func (a App) thumbnailHash(ctx context.Context, items []absto.Item) string {
-	ctx, end := tracer.StartSpan(ctx, a.tracer, "thumbnail_hash", trace.WithSpanKind(trace.SpanKindInternal))
+	ctx, end := tracer.StartSpan(ctx, a.tracer, "hash", trace.WithSpanKind(trace.SpanKindInternal))
 	defer end()
 
 	ids := make([]string, len(items))
@@ -288,7 +288,7 @@ func (a App) encodeContent(ctx context.Context, w io.Writer, isDone func() bool,
 		return
 	}
 
-	ctx, end := tracer.StartSpan(ctx, a.tracer, "thumbnail_encode", trace.WithSpanKind(trace.SpanKindInternal))
+	ctx, end := tracer.StartSpan(ctx, a.tracer, "encode", trace.WithSpanKind(trace.SpanKindInternal))
 	defer end()
 
 	reader, err := a.storageApp.ReadFrom(ctx, a.PathForScale(item, SmallSize))