Skip to content

Commit

Permalink
ci: Removing golint in favor of golangci-lint
Browse files Browse the repository at this point in the history
Signed-off-by: Vincent Boutour <[email protected]>
  • Loading branch information
ViBiOh committed Jul 28, 2022
1 parent f4726ed commit 1cc5330
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 7 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,7 @@ jobs:
uses: actions/setup-go@v3
with:
go-version: '^1.18'
- name: golangci-lint
uses: golangci/golangci-lint-action@v3

- name: Build
run: |
make
Expand Down
7 changes: 2 additions & 5 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,7 @@ app: init dev
init:
@curl --disable --silent --show-error --location --max-time 30 "https://raw.githubusercontent.com/ViBiOh/scripts/main/bootstrap" | bash -s -- "-c" "git_hooks" "coverage" "release"
go install "github.com/golang/mock/[email protected]"
go install "github.com/kisielk/errcheck@latest"
go install "golang.org/x/lint/golint@latest"
go install "github.com/golangci/golangci-lint/cmd/golangci-lint@latest"
go install "golang.org/x/tools/cmd/goimports@latest"
go install "mvdan.cc/gofumpt@latest"
go mod tidy
Expand All @@ -64,9 +63,7 @@ format:
## style: Check lint, code styling rules. e.g. pylint, phpcs, eslint, style (java) etc ...
.PHONY: style
style:
golint $(PACKAGES)
errcheck -ignoretests $(PACKAGES)
go vet $(PACKAGES)
golangci-lint run

## mocks: Generate mocks
.PHONY: mocks
Expand Down

0 comments on commit 1cc5330

Please sign in to comment.