Type: add a name field to track typedef names #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you want to work on translate-c and this helps with it then I'm OK with it. Let me know if you need help syncing the dependency. |
|
I don't mind trying to put together the dependency sync but is that the kind of commit that would need to come from a core team member? |
|
Good point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just an idea - as a stop-gap before #733 is implemented. This would allow more progress on aro translate-c since one blocker right now is the lack of typedef names. It was about 5 minutes of work so I'm not very strongly advocating for it if you think it's too much of a hack.
We had at least 4 bytes of padding available in
Typebecause it doesn't change the size ofTypein either Safe or Fast modes.