Fix OffsetArrays ambiguity resolution again #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since JuliaArrays/OffsetArrays.jl#157,
OffsetArrays.OffsetAxisKnownLength == Base.DimOrInd
, so the ambiguity-resolving method from #1 overwrites the earliersimilar
method, triggering a warning. This simply removes the method, which is not needed anymore.For this to work,
OffsetArrays
needs to be at version >=1.3, so I keep it as a dependency with a comment inProject.toml
(comments inProject.toml
are not preserved byPkg
operations unfortunately, but I think it's still better than no comment).