Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command-line tests for minidump and samplerate #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mojomojomojo
Copy link

These are the two command-line parameters for which it is feasible to construct deterministic tests.

@mojomojomojo
Copy link
Author

Out of curiosity, why is this a separate repo?

@CyberShadow
Copy link
Member

Thank you for this! I will try to make time to look at this and other PRs soon.

Out of curiosity, why is this a separate repo?

The files here are somewhat big and are binary files, people who just want to build Very Sleepy shouldn't be forced to download them (especially as Git will download all past versions of them by default).

@mojomojomojo
Copy link
Author

Won't the git submodule things built into the main repo download them anyway? I mean, it seems like a standard thing to get all the submodules. I had to do that in order to build at all.

@CyberShadow
Copy link
Member

Only if you clone with --recursive, and you can select which submodules to fetch if you want to. You can't really pick and choose when everything is in one Git repo, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants