Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option scrollExtentThreshold is not available #52

Closed
gabrielchaves7 opened this issue Apr 19, 2023 · 3 comments · Fixed by #59
Closed

Option scrollExtentThreshold is not available #52

gabrielchaves7 opened this issue Apr 19, 2023 · 3 comments · Fixed by #59
Assignees
@renancaraujo
Labels
documentation Improvements or additions to documentation

Comments

@gabrielchaves7
Copy link

gabrielchaves7 commented Apr 19, 2023 •
edited
Loading

Describe the bug
The package example shows a parameter called scrollExtentThreshold which is not available at version 0.7.0. Why it was removed??

To Reproduce
Steps to reproduce the behavior:

InfiniteList(scrollExtentThreshold: 100)
@mrocha98
Copy link

mrocha98 commented Sep 4, 2023

They removed scrollExtentThreshold in favor of cacheExtent on this PR: #42

@gabrielchaves7
Copy link
Author

Maybe this can be addressed just updating the readme/example

@tomarra tomarra moved this from Needs Triage to Todo in VGV Open Source 🦄 🧙🌟 Oct 26, 2023
@tomarra tomarra added the documentation Improvements or additions to documentation label Oct 26, 2023
@tomarra
Copy link
Contributor

tomarra commented Oct 26, 2023

Looks like we do still have scrollExtentThreshold in the README. Let's either remove this or get it updated to the new property that should be used.

@renancaraujo renancaraujo moved this from Todo to In Progress in VGV Open Source 🦄 🧙🌟 Oct 30, 2023
@renancaraujo renancaraujo self-assigned this Oct 30, 2023
@renancaraujo renancaraujo mentioned this issue Oct 30, 2023
Merged
7 tasks
@renancaraujo renancaraujo moved this from In Progress to In Review in VGV Open Source 🦄 🧙🌟 Oct 30, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in VGV Open Source 🦄 🧙🌟 Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@renancaraujo renancaraujo

Labels
documentation Improvements or additions to documentation
Projects
VGV Open Source 🦄 🧙🌟
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: update readme option docs VeryGoodOpenSource/very_good_infinite_list
4 participants
@tomarra @renancaraujo @mrocha98 @gabrielchaves7