Use HTML5 instead of HTML4 #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the change - it is slightly more concise, so I'm happy to merge it, but I do believe these result in the same behavior by browsers. While the new doctype you've given is the doctype specified by html5, it is not an html5 doctype, just an "html" doctype, suitable for all modern html. |
niloc132
approved these changes
Apr 17, 2022
niloc132
requested changes
Apr 17, 2022
Done. |
niloc132
approved these changes
Apr 18, 2022
treblereel
pushed a commit
to treblereel/j2clmavenplugin
that referenced
this pull request
May 6, 2022
Co-authored-by: andirady <[email protected]>
treblereel
pushed a commit
to treblereel/j2clmavenplugin
that referenced
this pull request
Jun 3, 2022
Co-authored-by: andirady <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since HTML5 is now the standard, I believe the HTML files shouldn't use HTML4 anymore.