Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Laravel 6.18 onward support #4

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add Laravel 6.18 onward support #4

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9820dfd
Laravel 6 support
pablo-bossi May 13, 2020
181389c
Add support for laravel 7
pablo-bossi Jul 14, 2020
18e9880
Version change to skip cache issues
pablo-bossi Jul 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@
"description": "Package to fast generate Resources in Larapi distribution. Very small, very simple but works.",
"require": {
"php": "^7.0",
"laravel/framework": "~5.6"
"laravel/framework": "~6.18"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Support for Laravel 6.18.

},
"require-dev": {
"phpunit/phpunit": "~6.0",
"mockery/mockery": "0.9.*"
"phpunit/phpunit": "~8.0",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated phpunit version required for laravel 6

"mockery/mockery": "1.3.*"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated mockery to meet phpUnit 8 needs

},
"autoload": {
"psr-4": {
Expand Down
6 changes: 3 additions & 3 deletions src/Command/stubs/service.stub
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ class DummyClass
{
$dummyname = $this->dummynameRepository->create($data);

$this->dispatcher->fire(new DummyModelWasCreated($dummyname));
$this->dispatcher->dispatch(new DummyModelWasCreated($dummyname));
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since laravel 5 fire has been deprecated in favor of dispatch, so updating it so generated services remains working properly


return $dummyname;
}
Expand All @@ -60,7 +60,7 @@ class DummyClass

$this->dummynameRepository->update($dummyname, $data);

$this->dispatcher->fire(new DummyModelWasUpdated($dummyname));
$this->dispatcher->dispatch(new DummyModelWasUpdated($dummyname));

return $dummyname;
}
Expand All @@ -71,7 +71,7 @@ class DummyClass

$this->dummynameRepository->delete($dummynameId);

$this->dispatcher->fire(new DummyModelWasDeleted($dummyname));
$this->dispatcher->dispatch(new DummyModelWasDeleted($dummyname));
}

private function getRequestedDummyModel($dummynameId)
Expand Down