Skip to content
This repository has been archived by the owner on Oct 13, 2021. It is now read-only.

Implement High-Resolution Settings (@2x/@3x/@4x) #21

Closed
RyleaStark opened this issue Nov 25, 2020 · 4 comments
Closed

Implement High-Resolution Settings (@2x/@3x/@4x) #21

RyleaStark opened this issue Nov 25, 2020 · 4 comments
Assignees
@RyleaStark
Labels
enhancement New feature or request Function:ACP Related to functionality in the Admin Function:Frontend Related to functionality in the Frontend UI:ACP Related to UI (Admin) UI:Frontend Related to UI (Frontend) XF 2.2.x XenForo Version 2.2.x
Milestone
v2.0.0

Comments

@RyleaStark
Copy link
Member

Implement options to define 2x and 3x src-sets for badges to improve resolution on devices that require the upscaled resolution.
@RyleaStark RyleaStark added enhancement New feature or request XF 2.2.x XenForo Version 2.2.x UI:Frontend Related to UI (Frontend) UI:ACP Related to UI (Admin) Function:Frontend Related to functionality in the Frontend Function:ACP Related to functionality in the Admin labels Nov 25, 2020
@RyleaStark RyleaStark changed the title Implement High-Resolution Settings (@2x/@3x) Implement High-Resolution Settings (@2x/@3x/@4x) Nov 26, 2020
@RyleaStark RyleaStark added this to the v2.0.0 milestone Nov 26, 2020
@RyleaStark RyleaStark self-assigned this Nov 26, 2020
@RyleaStark
Copy link
Member Author

Started. Added to Setup process.

XF-Badges/Setup.php

Lines 42 to 44 in 1e9605e

$table->addColumn('image_url_2x', 'varchar', 512)->setDefault('');
$table->addColumn('image_url_3x', 'varchar', 512)->setDefault('');
$table->addColumn('image_url_4x', 'varchar', 512)->setDefault('');

XF-Badges/Setup.php

Lines 59 to 61 in 1e9605e

$table->addColumn('image_url_2x', 'varchar', 512)->setDefault('');
$table->addColumn('image_url_3x', 'varchar', 512)->setDefault('');
$table->addColumn('image_url_4x', 'varchar', 512)->setDefault('');

XF-Badges/Setup.php

Lines 256 to 258 in 1e9605e

$table->addColumn('image_url_2x', 'varchar', 512)->after('image_url')->setDefault('');
$table->addColumn('image_url_3x', 'varchar', 512)->after('image_url_2x')->setDefault('');
$table->addColumn('image_url_4x', 'varchar', 512)->after('image_url_3x')->setDefault('');

XF-Badges/Setup.php

Lines 265 to 267 in 1e9605e

$table->addColumn('image_url_2x', 'varchar', 512)->after('image_url')->setDefault('');
$table->addColumn('image_url_3x', 'varchar', 512)->after('image_url_2x')->setDefault('');
$table->addColumn('image_url_4x', 'varchar', 512)->after('image_url_3x')->setDefault('');

@RyleaStark
Copy link
Member Author

//TODO: XenForo Template: CMTV_Badges_badge_edit Style Badge Preview grid

RyleaStark added a commit that referenced this issue Nov 30, 2020
@RyleaStark
v2.0.0a1
b60c3eb 
Check for limits as defined in permissions when displaying badges related to #16
Adds 2x,3x,4x image values to badges and categories #21
Replaced template matching with regular expression to improve tag selection.
@RyleaStark
Copy link
Member Author

RyleaStark commented Nov 30, 2020 •
edited
Loading

image
Added high-resolution settings in ACP. 1x is the only required definition.

@RyleaStark
Copy link
Member Author

image
Added preview display

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@RyleaStark RyleaStark

Labels
enhancement New feature or request Function:ACP Related to functionality in the Admin Function:Frontend Related to functionality in the Frontend UI:ACP Related to UI (Admin) UI:Frontend Related to UI (Frontend) XF 2.2.x XenForo Version 2.2.x
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
1 participant
@RyleaStark