Skip to content

Update NUnit to v5 #1943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SimonCropp merged 1 commit into from
Sep 28, 2026
Merged

Update NUnit to v5 #1943

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
<PackageVersion Include="Microsoft.Extensions.DependencyInjection" Version="10.0.12" />
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="18.10.1" />
<PackageVersion Include="Microsoft.Testing.Extensions.TrxReport" Version="2.4.1" />
<PackageVersion Include="NUnit" Version="4.6.1" />
<PackageVersion Include="NUnit" Version="5.0.0" />
<PackageVersion Include="MSTest.TestAdapter" Version="4.4.1" />
<PackageVersion Include="MSTest.TestFramework" Version="4.4.1" />
<PackageVersion Include="NUnit3TestAdapter" Version="6.3.0" />
Expand Down
1 change: 1 addition & 0 deletions src/Verify.NUnit.DerivePaths.Tests/Verify.NUnit.DerivePaths.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
<ItemGroup>
<PackageReference Include="Microsoft.Testing.Extensions.TrxReport" />
<PackageReference Include="NUnit3TestAdapter" />
<PackageReference Include="System.ValueTuple" VersionOverride="4.6.2" />
<PackageReference Include="ProjectDefaults" PrivateAssets="all" />
<ProjectReference Include="..\Verify.NUnit\Verify.NUnit.csproj" />
<ProjectReference Include="..\Verify\Verify.csproj" />
Expand Down
1 change: 1 addition & 0 deletions src/Verify.NUnit.DisableAttachments.Tests/Verify.NUnit.DisableAttachments.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
<ItemGroup>
<PackageReference Include="Microsoft.Testing.Extensions.TrxReport" />
<PackageReference Include="NUnit3TestAdapter" />
<PackageReference Include="System.ValueTuple" VersionOverride="4.6.2" />
<PackageReference Include="ProjectDefaults" PrivateAssets="all" />

<ProjectReference Include="..\TargetLibrary\TargetLibrary.csproj" />
Expand Down
1 change: 1 addition & 0 deletions src/Verify.NUnit.Tests/Verify.NUnit.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
<ItemGroup>
<PackageReference Include="Microsoft.Testing.Extensions.TrxReport" />
<PackageReference Include="NUnit3TestAdapter" />
<PackageReference Include="System.ValueTuple" VersionOverride="4.6.2" />
<PackageReference Include="ProjectDefaults" PrivateAssets="all" />

<ProjectReference Include="..\TargetLibrary\TargetLibrary.csproj" />
Expand Down
8 changes: 4 additions & 4 deletions src/Verify.NUnit.Tests/VerifyInOneTimeSetUp.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@
public class VerifyInOneTimeSetUp
{
[OneTimeSetUp]
public void SetUp()
public async Task SetUp()
{
var exception = ThrowsAsync<Exception>(
() => Verify("If I call verify in a fixtures One Time SetUp method, then test method is not available for the verify file name."))!;
That(exception.Message, Is.EqualTo("TestContext.CurrentContext.Test.Method is null. Verify can only be used from within a test method."));
var exception = await ThrowsAsync<Exception>(
() => Verify("If I call verify in a fixtures One Time SetUp method, then test method is not available for the verify file name."));
That(exception!.Message, Is.EqualTo("TestContext.CurrentContext.Test.Method is null. Verify can only be used from within a test method."));
}

[Test]
Expand Down
3 changes: 2 additions & 1 deletion src/Verify.NUnit/Verify.NUnit.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<TargetFrameworks Condition=" '$(OS)' == 'Windows_NT'">net462;net472;net48</TargetFrameworks>
<TargetFrameworks>$(TargetFrameworks);net6.0;net7.0;net8.0;net9.0;net10.0;net11.0</TargetFrameworks>
<TargetFrameworks>$(TargetFrameworks);net8.0;net9.0;net10.0;net11.0</TargetFrameworks>
</PropertyGroup>

<ItemGroup>
Expand All @@ -18,6 +18,7 @@

<ItemGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETFramework'">
<Reference Include="System.IO.Compression" />
<PackageReference Include="System.ValueTuple" VersionOverride="4.6.2" />
</ItemGroup>

</Project>
Loading