Format UTC offsets with invariant culture - #1855
Closed
SimonCropp wants to merge 1 commit into
Closed
Conversation
GetDateOffset used plain interpolation, so the numbers were rendered with CurrentCulture while the rest of DateFormatter uses InvariantCulture. Under a culture with a non-ascii negative sign (for example ar-SA, which uses U+061C followed by "-") a DateTimeOffset with a negative offset produced a parameter string, and hence a file name, that never matched a snapshot committed from an en-US machine. The same value also leaked into snapshot content via Convert when date scrubbing is off.
Member
Author
|
Duplicate of #1854, which covers the same fix with a wider theory (all five branches, including zero) and uses the real sv-SE U+2212 sign rather than an invented one. Closing in favour of that. #1868 (sub-hour offsets) was stacked on this branch and is being rebased onto |
This was referenced Aug 26, 2026
This was referenced Aug 27, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DateFormatter.GetDateOffsetrendered the offset numbers with plain interpolation, so they usedCurrentCulturewhile every other format call inDateFormatterpassesCulture.InvariantCulture.Under a culture whose negative sign is not
-(for examplear-SA, which uses U+061C followed by-), aDateTimeOffsetparameter with a negative offset produced a parameter string, and hence a file name, that never matched a snapshot committed from an en-US machine. The same value also leaked into snapshot content viaConvertwhen date scrubbing is off.All four format calls now go through
Culture.InvariantCulture. Output is unchanged for cultures that already use the invariant signs.Added
DateFormatterTests.OffsetIsNotAffectedByCurrentCulture, which formats under a culture with a custom negative sign. It fails onmainand passes with this change. FullVerify.Testssuite passes.