Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove requirement for [UsesVerify] on xunit tests #1131

Merged
merged 13 commits into from
Jan 17, 2024

Conversation

SimonCropp
Copy link
Member

@SimonCropp SimonCropp commented Jan 16, 2024

xUnit now has an api that renders [UsesVerify] redundant.

It can be remove it from all tests

@SimonCropp SimonCropp changed the title Assembly level use verify attribute for xunit Remove requirement for [UsesVerify] on xunit tests Jan 16, 2024
@SimonCropp SimonCropp added this to the 23.0.0 milestone Jan 16, 2024
@SimonCropp SimonCropp merged commit ab9f931 into main Jan 17, 2024
2 of 4 checks passed
@SimonCropp SimonCropp deleted the assembly-level-use-verify-attribute-for-xunit branch January 17, 2024 08:44
@github-actions github-actions bot restored the assembly-level-use-verify-attribute-for-xunit branch January 17, 2024 08:45
@SimonCropp SimonCropp deleted the assembly-level-use-verify-attribute-for-xunit branch January 17, 2024 09:42
edumserrano added a commit to edumserrano/share-jobs-data that referenced this pull request Jan 19, 2024
edumserrano added a commit to edumserrano/share-jobs-data that referenced this pull request Jan 19, 2024
* Bump the nuget group in /ShareJobsData with 1 update

Bumps the nuget group in /ShareJobsData with 1 update: [Verify.Xunit](https://github.com/VerifyTests/Verify).


Updates `Verify.Xunit` from 22.11.5 to 23.0.0
- [Release notes](https://github.com/VerifyTests/Verify/releases)
- [Commits](VerifyTests/Verify@22.11.5...23.0.0)

---
updated-dependencies:
- dependency-name: Verify.Xunit
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: nuget
...

Signed-off-by: dependabot[bot] <[email protected]>

* remove deprecated UsesVerify attribute

Related with VerifyTests/Verify#1131

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Eduardo Serrano <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants