Viewer respects max instances - #855
Merged
Merged
Conversation
The viewer was exempt from the cap on the grounds that it queues rather than opening a window per pair. That is true of the second pair and every one after it, and false of the first: with nothing owning the queue, AddDiff starts a process. So MaxInstancesToLaunch(0) - "no window opens" - opened one, and a run with no tray put a viewer on screen per staged snapshot with nothing available to stop it. The check goes in ViewerLaunchGate, which is the only place that knows which of the two is happening, and after the ownership probe. A caller that asked would charge all twenty of a parallel run's callers for the one window between them, and the nineteen that find the owner would be capped out of forwarding their pairs to it. Capped is its own outcome so AddDiff can report TooManyRunningDiffTools rather than folding it in with a tool that could not be found.
This was referenced Aug 26, 2026
Bump DiffEngine from 20.0.0-beta.34 to 20.1.1
NServiceBusCommunity/NServiceBus.Community.Serilog#901
Closed
This was referenced Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.