Guard the menu and hotkey delete paths - #813
Merged
Merged
Conversation
The wire path deletes through AcceptTracked, which catches, re-tracks so the delete can be retried, and reports why it failed. The menu and hot key paths called File.Delete straight. So a read-only or open verified file threw out of a click handler, onto the UI thread, where nothing hooks Application.ThreadException. The entry had already been untracked by then, so the pending delete was lost with the exception. In AcceptAll it was worse: the first bad delete skipped the remaining deletes, every pending move and all the snapshots, so "Accept all" quietly stopped at the first file it could not remove. All three now go through AcceptTracked, and AcceptAllDeletes drops its Clear - a failed delete re-tracks itself, and clearing afterwards would throw that away again. Failures are logged rather than shown, since a read-only file is not worth an exception dialog.
This was referenced Aug 26, 2026
This was referenced Aug 27, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wire path deletes through AcceptTracked, which catches, re-tracks so the
delete can be retried, and reports why it failed. The menu and hot key paths
called File.Delete straight.
So a read-only or open verified file threw out of a click handler, onto the UI
thread, where nothing hooks Application.ThreadException. The entry had already
been untracked by then, so the pending delete was lost with the exception. In
AcceptAll it was worse: the first bad delete skipped the remaining deletes,
every pending move and all the snapshots, so "Accept all" quietly stopped at the
first file it could not remove.
All three now go through AcceptTracked, and AcceptAllDeletes drops its Clear -
a failed delete re-tracks itself, and clearing afterwards would throw that away
again. Failures are logged rather than shown, since a read-only file is not
worth an exception dialog.