Validate the path, not the parameter name - #807
Merged
Conversation
Guard.FileExists called AgainstEmpty(argumentName, path) - arguments reversed,
so the empty check ran against the literal parameter name, which is never empty.
An empty path fell straight through to ArgumentException("File not found. Path:
") with no ParamName, which names neither the argument nor the file.
The same commit stops OsSettingsResolver dereferencing a null PATH. `env -i` and
some service launchers do start a process without one, and this runs in a static
constructor, so the NullReferenceException is permanent for the process. An
empty PATH just means no tool is found that way, which is a perfectly good
answer.
No test for the PATH half: it is read once by a type initialiser, so it cannot
be exercised twice in one process.
This was referenced Aug 26, 2026
This was referenced Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guard.FileExists called AgainstEmpty(argumentName, path) - arguments reversed,
so the empty check ran against the literal parameter name, which is never empty.
An empty path fell straight through to ArgumentException("File not found. Path:
") with no ParamName, which names neither the argument nor the file.
The same commit stops OsSettingsResolver dereferencing a null PATH.
env -iandsome service launchers do start a process without one, and this runs in a static
constructor, so the NullReferenceException is permanent for the process. An
empty PATH just means no tool is found that way, which is a perfectly good
answer.
No test for the PATH half: it is read once by a type initialiser, so it cannot
be exercised twice in one process.