Match extensions case insensitively - #801
Merged
Merged
Conversation
ExtensionLookup, PathLookup and BinaryExtensions all compared ordinally, while every registration is lowercase. The file systems that produce these strings are not case sensitive on Windows or macOS, so .PNG, .JPG and .Docx matched nothing: the tool resolved for foo.png and not for foo.PNG, and the same file could get a diff tool or not depending on how it happened to be named. BinaryExtensions decides whether a pair is treated as binary, so the same mismatch also picks the wrong argument builder for a tool that has both. Viewer/ImageExtensions already uses OrdinalIgnoreCase for exactly this kind of lookup, so this makes the two agree rather than introducing a new rule.
This was referenced Aug 26, 2026
This was referenced Aug 27, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ExtensionLookup, PathLookup and BinaryExtensions all compared ordinally, while
every registration is lowercase. The file systems that produce these strings are
not case sensitive on Windows or macOS, so .PNG, .JPG and .Docx matched nothing:
the tool resolved for foo.png and not for foo.PNG, and the same file could get a
diff tool or not depending on how it happened to be named.
BinaryExtensions decides whether a pair is treated as binary, so the same
mismatch also picks the wrong argument builder for a tool that has both.
Viewer/ImageExtensions already uses OrdinalIgnoreCase for exactly this kind of
lookup, so this makes the two agree rather than introducing a new rule.