Fall through when the tray has gone - #792
Merged
Merged
Conversation
PendingFiles routes on DiffEngineTray.IsRunning, which a type initialiser reads once. CLAUDE.md documents the late-starting tray - a tray that appears after the test host, which the queue owner branch already handles. This is the mirror case, and nothing handled it. A tray that exits while a long lived host keeps running leaves that cached answer saying a tray is there. The piper send then went to a port nobody was listening on, and returned void: the refusal was swallowed into a trace line and the caller carried on believing it had handed the file over. Every later move and delete for the life of that process was pending in nothing at all - no fallback to the queue owner, and no LaunchDelete either. Have the piper send report whether it connected, and treat a refusal the same as no tray. That is the branch that already exists and already knows what to do.
This was referenced Aug 26, 2026
This was referenced Aug 27, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PendingFiles routes on DiffEngineTray.IsRunning, which a type initialiser reads
once. CLAUDE.md documents the late-starting tray - a tray that appears after the
test host, which the queue owner branch already handles. This is the mirror
case, and nothing handled it.
A tray that exits while a long lived host keeps running leaves that cached
answer saying a tray is there. The piper send then went to a port nobody was
listening on, and returned void: the refusal was swallowed into a trace line and
the caller carried on believing it had handed the file over. Every later move
and delete for the life of that process was pending in nothing at all - no
fallback to the queue owner, and no LaunchDelete either.
Have the piper send report whether it connected, and treat a refusal the same as
no tray. That is the branch that already exists and already knows what to do.