Skip to content

Fall through when the tray has gone - #792

Merged
SimonCropp merged 1 commit into
mainfrom
fix-pending-files-tray-gone
Aug 22, 2026
Merged

Fall through when the tray has gone#792
SimonCropp merged 1 commit into
mainfrom
fix-pending-files-tray-gone

Conversation

@SimonCropp

Copy link
Copy Markdown
Member

PendingFiles routes on DiffEngineTray.IsRunning, which a type initialiser reads
once. CLAUDE.md documents the late-starting tray - a tray that appears after the
test host, which the queue owner branch already handles. This is the mirror
case, and nothing handled it.

A tray that exits while a long lived host keeps running leaves that cached
answer saying a tray is there. The piper send then went to a port nobody was
listening on, and returned void: the refusal was swallowed into a trace line and
the caller carried on believing it had handed the file over. Every later move
and delete for the life of that process was pending in nothing at all - no
fallback to the queue owner, and no LaunchDelete either.

Have the piper send report whether it connected, and treat a refusal the same as
no tray. That is the branch that already exists and already knows what to do.

PendingFiles routes on DiffEngineTray.IsRunning, which a type initialiser reads
once. CLAUDE.md documents the late-starting tray - a tray that appears after the
test host, which the queue owner branch already handles. This is the mirror
case, and nothing handled it.

A tray that exits while a long lived host keeps running leaves that cached
answer saying a tray is there. The piper send then went to a port nobody was
listening on, and returned void: the refusal was swallowed into a trace line and
the caller carried on believing it had handed the file over. Every later move
and delete for the life of that process was pending in nothing at all - no
fallback to the queue owner, and no LaunchDelete either.

Have the piper send report whether it connected, and treat a refusal the same as
no tray. That is the branch that already exists and already knows what to do.
@SimonCropp SimonCropp added this to the 20.0.0 milestone Aug 22, 2026
@SimonCropp
SimonCropp merged commit 4c4f6c8 into main Aug 22, 2026
9 checks passed
@SimonCropp
SimonCropp deleted the fix-pending-files-tray-gone branch August 22, 2026 00:45
This was referenced Aug 26, 2026
This was referenced Aug 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant